Dynamic constraint to check naming convention of a failure mode ID

Question

Hello, I have created a dynamic constraint to check that the failure mode ids of my elements follow the naming convention we have defined, i.e., Subpartname + _FM + digits + p (for permanent faults) or t (for transient faults). It seems that the test of my regular expression does not work. Could you help me finding the issue? script: inv:
if self.mediniGetContainer() <> null then

let
Subpart: sysml::SysMLPart = self.mediniGetContainer(),
MessageArg1: String = self.id.toString(),
MessageArg2: String = Subpart.name.toString()
in
if not self.id.oclIsUndefined() and self.id <> '' and not MessageArg2.oclIsUndefined() and MessageArg2 <> '' then
if self.failureType = 'PERMANENT' then
MessageArg1.matches('^' + MessageArg2 + '_FM\d+p$')
else
MessageArg1.matches('^' + MessageArg2 + '_FM\d+t$')
endif
else
true
endif
else
true
endif The message is The failure mode ID {1} in element {2} does not follow the element naming convention ELEMENT_NAME + _FM + digits + p (for permanent faults) or t (for transient faults). Thank you, Romain

medini_1063023713 · Answer

Thank you very much Jan!

It works indeed. I was focusing on the correctness of the regular expression and missed that obvious mistake. That's why a second pair of eyes is always useful :-)

Somehow I could not identify this issue as I was overwhelmed with the reported >10.000 failure mode naming convention violations. Now, I can still see that I have quite a few that do not respect my naming convention but with a much more respectable number.  ;-)

medini_1024169437 · Answer

Romain, after some debug session I fugured that the pattern that was used was always ^P_FM\d+t$ though I was expecting ^P_FM\d+p$ so I checked again and found out that the line

if self.failureType = 'PERMANENT' then

is the root cause as it compares a enum with a string, The right way is

if self.failureType = safetyModel::FailureType::PERMANENT then

Happy OCL Scripting

Jan

medini_1024169437 · Answer

Romain, I need to check. Regular expressions usually have their own "will" sometimes :-)

Jan